Skip to content

client->closed has incorrect scope #183

Closed
ghazel opened this Issue Jun 17, 2011 · 2 comments

2 participants

@ghazel
Collaborator
ghazel commented Jun 17, 2011

Only relevant (at the moment) to people using client.socket from ruby, but client->closed = 0 in C occurs too early - after mysql_init, instead of when client->net.fd is actually set, which is after mysql_real_connect returns.

Simply moving client->closed = 0 however is not enough, since nogvl_close should still call mysql_close/xfree even if mysql_real_connect was never called. So, I'm filing this ticket until someone can add an "initialized" state or similar.

@tenderlove
Collaborator

I don't understand what's going on here. Could you post some sample code to help describe the problem?

@ghazel
Collaborator
ghazel commented Mar 30, 2012

I forget why I was using the socket from ruby, but I made this note after working with the C code for a bit. If no one else uses the socket it probably doesn't matter.

@ghazel ghazel closed this Mar 30, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.