-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP 7 nightly: Declaration of Carbon\Carbon::createFromFormat() should be compatible with... #282
Comments
Yes... as per: |
I see 😕 |
Yes we will, first RC isn't due until June though but we'll get something in soon enough. Interesting though PHP 7 was just added to the test matrix and its passing... guess the referenced changed hasn't been merged yet for travis. |
My build is failing because I convert all PHP errors (even notices) into exceptions, you have in build only notice "PHP Strict Standards..." https://travis-ci.org/briannesbitt/Carbon/jobs/52878652 |
I don't have time to do a PR (or more honestly, learn about PRs because I've never done one), but I'm using Rasmus' php7dev vagrant box and ran across this error. I seed 30ish tables with Laravel's artisan db:seed command and they all require Carbon timestamps. I was able to get the seeding working correctly by changing the arguments for this method (line 379 or thereabouts) from
The seeding was successful after this change. Hope that's useful. |
@kenmulford this solution works fine on php 7 or later but on php 5 throws errors. |
Correct, I should have clarified it's a b/c break. I was thinking it'd be useful in the context of the php7 test builds for anyone else trying to test apps. |
Now that 7.0.0alpha 1 is out, do we have a fix or workaround for this? A brand new Laravel 5.1 project fails with this exception. |
Still lots of conversation here: php/php-src@8e19705#commitcomment-11644892 |
I got this to work across PHP versions by adding a simple php version check in Carbon.php from line 374
|
so uhh, when will this be fixed? |
This is fixed. |
alpha 2 fixed it |
Yes, looks like it has been fixed. |
This issue can be closed now. :) |
I still have this error on php7 & carbon. |
It was fixed on alpha 2. |
You must be using an older version of php7. |
Indeed, had to re-compile php7. Thanks for the heads up & sorry for the trouble. 😃 |
My build on travis has an error after added PHP 7 nightly to the test matrix:
Can someone confirm this issue?
The text was updated successfully, but these errors were encountered: