Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diffForHumans() gives incorrect wording for SLOVAK language #2993

Closed
pkundis opened this issue Apr 6, 2024 · 1 comment · Fixed by #2995
Closed

diffForHumans() gives incorrect wording for SLOVAK language #2993

pkundis opened this issue Apr 6, 2024 · 1 comment · Fixed by #2995
Labels
translation Rely to internationalization

Comments

@pkundis
Copy link
Contributor

pkundis commented Apr 6, 2024

Hello,

I encountered an issue with the following code for Slovak language if the number of seconds, minutes, ..., years is 5+

$lastActive = Carbon::createFromFormat('Y-m-d H:i:s', $this->last_active_at);
return $lastActive->diffForHumans();

Carbon version: 2.72.3 (laravel/framework v10.48.4)

PHP version: 8.1

See below the correct wording for the Slovak language and the values I am actually getting.
It seems the code is mixing wording for "in X hours" instead of "x hours ago" once the number is 5 or higher.

Example:
4 hours ago should be pred 4 hodinami <-- CORRECT
5 hours ago should be pred 5 hodinami but getting 5 hodín that is a Slovak wording for in 5 hours

// SECONDS
pred 1 sekundou (1 second ago) <-- CORRECT
pred 2 sekundami (2 seconds ago) <-- CORRECT
pred 3 sekundami (3 seconds ago) <-- CORRECT
pred 4 sekundami (4 seconds ago) <-- CORRECT
pred 5 sekundami (5 seconds ago) <-- INCCORECT getting "pred 5 sekúnd"
pred 6 sekundami (6 seconds ago) <-- INCCORECT getting "pred 6 sekúnd"
.
.
.
pred 59 sekundami (59 seconds ago) <-- INCCORECT getting "pred 59 sekúnd"

// MINUTES
pred 1 minútou (1 minute ago) <-- CORRECT
pred 2 minútami (2 minutes ago) <-- CORRECT
pred 3 minútami (3 minutes ago) <-- CORRECT
pred 4 minútami (4 minutes ago) <-- CORRECT
pred 5 minútami (5 minutes ago) <-- INCCORECT getting "pred 5 minút"
pred 6 minútami (6 minutes ago) <-- INCCORECT getting "pred 6 minút"
.
.
.
pred 59 minútami (59 minutes ago) <-- INCCORECT getting "pred 59 minút"

// HOURS
pred 1 hodinou (1 hour ago) <-- CORRECT
pred 2 hodinami (2 hours ago) <-- CORRECT
pred 3 hodinami (3 hours ago) <-- CORRECT
pred 4 hodinami (4 hours ago) <-- CORRECT
pred 5 hodinami (5 hours ago) <-- INCCORECT getting "pred 5 hodín"
pred 6 hodinami (6 hours ago) <-- INCCORECT getting "pred 6 hodín"
.
.
.
pred 23 hodinami (23 hours ago) <-- INCCORECT getting "pred 23 hodín"

// DAYS
pred 1 dňom (1 day ago) <-- CORRECT
pred 2 dňami (2 days ago) <-- CORRECT
pred 3 dňami (3 days ago) <-- CORRECT
pred 4 dňami (4 days ago) <-- CORRECT
pred 5 dňami (5 days ago) <-- INCCORECT getting "pred 5 dni"
pred 6 dňami (6 days ago) <-- INCCORECT getting "pred 6 dni"
.
.
.
pred 30 dňami (30 days ago) <-- INCCORECT getting "pred 30 dni"

// WEEKS (ALL CORRECT AS THERE IS ONLY 4)
pred 1 týždňom (1 week ago) <-- CORRECT
pred 2 týždňami (2 weeks ago) <-- CORRECT
pred 3 týždňami (3 weeks ago) <-- CORRECT
pred 4 týždňami (4 weeks ago) <-- CORRECT

// MONTHS
pred 1 mesiacom (1 month ago) <-- CORRECT
pred 2 mesiacmi (2 months ago) <-- CORRECT
pred 3 mesiacmi (3 months ago) <-- CORRECT
pred 4 mesiacmi (4 months ago) <-- CORRECT
pred 5 mesiacmi (5 months ago) <-- INCCORECT getting "pred 5 mesiacov"
pred 6 mesiacmi (6 months ago) <-- INCCORECT getting "pred 6 mesiacov"
.
.
.
pred 11 mesiacmi (11 months ago) <-- INCCORECT getting "pred 11 mesiacov"

// YEARS
pred 1 rokom (1 year ago) <-- CORRECT
pred 2 rokmi (2 years ago) <-- CORRECT
pred 3 rokmi (3 years ago) <-- CORRECT
pred 4 rokmi (4 years ago) <-- CORRECT
pred 5 rokmi (5 years ago) <-- INCCORECT getting "pred 5 rokov"
pred 6 rokmi (6 years ago) <-- INCCORECT getting "pred 6 rokov"
.
.
.
pred XY rokmi (XY years ago) <-- INCCORECT getting "pred XY rokov"

Thanks!

@kylekatarnls kylekatarnls added the translation Rely to internationalization label Apr 6, 2024
kylekatarnls added a commit that referenced this issue Apr 7, 2024
Fix #2993

Co-authored-by: pkundis <pkundis@users.noreply.github.com>
kylekatarnls added a commit that referenced this issue Apr 7, 2024
Fix #2993

Co-authored-by: pkundis <pkundis@users.noreply.github.com>
@kylekatarnls
Copy link
Collaborator

Hello, the replacements of those words when they are after "pred" are done here, can you check the update that include both plural and their replacement:

https://github.com/briannesbitt/Carbon/pull/2995/files

kylekatarnls added a commit that referenced this issue Apr 16, 2024
Fix #2993

Co-authored-by: pkundis <pkundis@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation Rely to internationalization
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants