Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiple : true to the $mdDialog ? #100

Open
Greyg-POPEI opened this issue Mar 2, 2017 · 7 comments
Open

Add multiple : true to the $mdDialog ? #100

Greyg-POPEI opened this issue Mar 2, 2017 · 7 comments
Assignees
Milestone

Comments

@Greyg-POPEI
Copy link

Hello, thank you for your plugin.

I would like to use it inside a $mdDialog, is it possible to add the multiple option for the $mdDialog ?

Thanks

@jamesselfpay
Copy link

I'm having the same issue. Ever since the 1.1.2 release of angular material, the color picker inside a $mdDialog will close the dialog

https://github.com/angular/material/blob/master/CHANGELOG.md

@gsfitis
Copy link

gsfitis commented Mar 22, 2017

Hello,

I was having the same issue. So i dig inside dist/mdColorPicker.js. The plugin is using skipHide to implement the multi dialog functionality but skipHide is removed from angular material. They added the multiple option, so go inside dist/mdColorPicker.js search for skipHide and replace it with multiple and that's it.

I hope a next version @brianpkelley will implement that new option instead of skipHide.

@schlotzz
Copy link

+1

@fivjagetiya
Copy link

Is this fixed in the latest version

@parmarsanjay
Copy link

+1

@tit1
Copy link

tit1 commented Jun 26, 2017

This is related to issue #111 and appears to have been fixed in PR #107. Can this be merged?

@mrmashal
Copy link

I set default options for $mdDialog.show like this in my module config to work around this issue:

        .config(function($provide) {
            // Decorate the $mdDialog service using $provide.decorator
            $provide.decorator("$mdDialog", function ($delegate) {
                // Get a handle of the show method
                var methodHandle = $delegate.show;
                function decorateDialogShow () {
                    var args = angular.extend({}, arguments[0], { multiple: true })
                    return methodHandle(args);
                }
                $delegate.show = decorateDialogShow; 
                return $delegate;
            });
        });

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants