Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issues #24 and #25 #26

Merged
merged 3 commits into from Nov 20, 2013
Merged

Fix Issues #24 and #25 #26

merged 3 commits into from Nov 20, 2013

Conversation

pebreo
Copy link
Contributor

@pebreo pebreo commented Nov 13, 2013

This is my pull request to fix issue #24 and #25.

Issue #24 was about changing the syntax f = open(..) to with open(..) as f

Issue #25 was about generating the *.xls files into their own subdirectory tests/generated_files

A bunch of *_tests.py have been affected but the non-test files that have been affected are:

document_writers.py
textwidths.py

All tests have passed as a result of these changes.

brianray added a commit that referenced this pull request Nov 20, 2013
@brianray brianray merged commit 25ca295 into brianray:master Nov 20, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants