Skip to content
This repository has been archived by the owner on May 30, 2020. It is now read-only.

Add x86_64-pc-windows-msvc and i686-pc-windows-msvc configurations #5

Closed
briansmith opened this issue Oct 26, 2015 · 4 comments
Closed

Comments

@briansmith
Copy link
Owner

Unfortunately, crypto-bench doesn't build on pc-windows-msvc now because several of the libraries fail to build. As Cargo.toml only supports adding dependencies per-target, not removing them, that means we'd need to add an exhaustive set of configurations to Cargo.toml in order to get this to work. Hopefully the instead the libraries will soon improve so that they build and work correctly on pc-windows-msvc.

@briansmith
Copy link
Owner Author

Also, when this is done, an Appveyor CI config should be checked in, and Brian should update his Appveyor config to enable it for this repo.

@briansmith
Copy link
Owner Author

@ctz has made some progress on rust-fastpbkdf2 at ctz/rust-fastpbkdf2#1.
rust-crypto now builds and works on -msvc, after DaGenix/rust-crypto#324.
I am probably going to change rust-openssl to be Linux- (and maybe Mac-) only, to work around the difficulty in getting it working when OpenSSL isn't already installed as a system library.

@briansmith
Copy link
Owner Author

After 8a073da, we can now use cargo_all bench to run whichever benchmarks actually work on Windows. The Appveyor configuration is still pending.

@briansmith
Copy link
Owner Author

I'm closing this. I run crypto-bench on ring on -msvc regularly lately. I'll file a separate issue for Appveyor.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant