You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We should turn on the strictest "warn about any unused return values" warnings that every compiler (GCC, clang, MSVC) supports. Unfortunately, it seems like in general compilers don't have such a warning.
If we can't make compilers warn about ignored return values without annotations, then we should add the annotations. In GCC this is __attribute__((warn_unused_result)). MSVC has one as well; see the documentation about SAL annotations. This should all abstracted using a macro to be defined in crypto/internal.h, named something like OPENSSL_WARN_UNUSED_RESULT.
Notes:
There are likely a lot of small changes that are needed. Try to split the changes up into multiple commits.
The GCC/clang work can be done separately from the MSVC work.
The text was updated successfully, but these errors were encountered:
__attribute__((warn_unused_result))
. MSVC has one as well; see the documentation about SAL annotations. This should all abstracted using a macro to be defined in crypto/internal.h, named something likeOPENSSL_WARN_UNUSED_RESULT
.Notes:
The text was updated successfully, but these errors were encountered: