Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internals: "fast detection" for collection iteration doesn't work for non-stable versions #100

Closed
briantist opened this issue Oct 1, 2023 · 0 comments · Fixed by #104
Closed
Labels
bug Something isn't working

Comments

@briantist
Copy link
Owner

f_namespace, f_name, f_version = p.name.replace('.tar.gz', '').split('-')

Pretty minor, but the fast detection will never work for a version that contains a hyphen like 1.2.3-alpha because the split will have more than 3 results.

This should be fixable by setting the second argument of split to 3.

This "failure" really just means falling back to "slow" detection that requires some additional requests.

@briantist briantist added the bug Something isn't working label Oct 1, 2023
@briantist briantist changed the title internals: "fast detection" for collection iteration doesn't work for non-stale versions internals: "fast detection" for collection iteration doesn't work for non-stable versions Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant