Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forcing page counts onto upstream URLs broke v2 proxying partially #113

Closed
briantist opened this issue Oct 8, 2023 · 0 comments · Fixed by #114
Closed

Forcing page counts onto upstream URLs broke v2 proxying partially #113

briantist opened this issue Oct 8, 2023 · 0 comments · Fixed by #114
Labels
bug Something isn't working
Milestone

Comments

@briantist
Copy link
Owner

In #104 I had all upstream requests add on query string parameters to set the page size to 100, which helps reduce number of roundtrips with old clients, and slightly mitigates #99.

The page size parameters are different between v2 and v3, page_size and limit respectively and I lazily just added both to all URLs.

But it turns out that old galaxy throws a 400 error on the parameter it doesn't recognize, so that's causing failures on some paginated requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant