Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note for required go version on readme #26

Closed
mingrammer opened this issue Aug 20, 2018 · 3 comments
Closed

Note for required go version on readme #26

mingrammer opened this issue Aug 20, 2018 · 3 comments

Comments

@mingrammer
Copy link
Contributor

mingrammer commented Aug 20, 2018

Hi.

I'm using your gofakeit in my cli open source, the flog

Today, I've tried the installing the flog in centos:latest docker, but go get failed with undefined: math.Round error message. Yes, the Round method is available since Go 1.10. I didn't know it.

So, I think it is good idea that notes the required Go version on README to let users know the required Go version to use gofakeit.

How about you?

@brianvoe
Copy link
Owner

Oh good catch! Ill probably see if i can work it back so lower versions can use it.

@brianvoe
Copy link
Owner

Ok i replaced math.Round with math.Floor just cause the package itself is good for the earliest version of go. So i updated it and added v1.0 to travis to test against. So we should be good. v3.11.5

Thanks

P.S. It looks like you use a good amount of gofakeit in your package it would be really nice if you could put in your readme your use of gofakeit so it can help get some more eyes on the package.

@mingrammer
Copy link
Contributor Author

Thank you for update :)

Ya, I'll update my readme!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants