Proposal: API for providing HttpDataSource

[ZacSweers]

ExoPlayer allows for providing a custom HttpDataSource. One such use would be providing your own, more up-to-date OkHttpClient instance rather than relying on the older one in the Android framework. It's also useful if you have custom logging in your HttpClient implementation that you'd like to track in the video.

[brianwernick]

I like this idea however it will have to wait until a 3.x version

[se-bastiaan]

You can provide your own RenderBuilder by using setVideoURI(Uri uri, RenderBuilder renderBuilder) in which you use a different DataSource. Bit more work than just providing a DataSource, but it's possible.

[ZacSweers]

RenderBuilder doesn't provide the option for specifying your own DataSource as far as I can see? Unless you mean overriding buildRenderers

[brianwernick]

@hzsweers You would need to create your own RenderBuilder and specify a DataSource of your own. See RenderBuilder-Line#79

[brianwernick]

Because this isn't a major issue and the ability to specify the DataSource via the RenderBuilders already exists, I'm moving a more simplified solution to a later 3.x release

[ZacSweers]

I would argue this is a significant issue and specifying via datarenderers isn't simple, but I suppose it's down to the consumer. At the very least, a sample or wiki example would be good to have in the meantime.

[MrArca9]

Any updates on this?

I would love to be able to set HTTPHeaders for HLS Requests.

[brianwernick]

No, It's a low-priority issue as you can specify you own DataSource via the RenderBuilders currently

[MrArca9]

Alright, i actually just removed exomedia and used the demo exoPlayer as it was easier to set it that way.

[brianwernick]

I'm not sure why that is easier than just specifying your own RenderBuilder but I'm happy it works for you

[SalmanTKhan]

Where do you supply your own RenderBuilder? I guess that was a dumb question but during setVideoURI

/**
* Sets the Uri location for the video to play
*
* @param uri The video's Uri
* @param renderBuilder RenderBuilder that should be used
*/
public void setVideoURI(@nullable Uri uri, @nullable RenderBuilder renderBuilder)

[brianwernick]

This functionality has been added to the working 4.0.0 branch. The Demo's App.java has an example, but for posterity I'm reproducing it here as well.

// Registers the media sources to use the OkHttp client instead of the standard Apache one
// Note: the OkHttpDataSourceFactory can be found in the ExoPlayer extension library `extension-okhttp`
ExoMedia.setHttpDataSourceFactoryProvider(new ExoMedia.HttpDataSourceFactoryProvider() {
    @Override
    public HttpDataSource.BaseFactory provide(@NonNull String userAgent, @Nullable TransferListener<? super DataSource> listener) {
        return new OkHttpDataSourceFactory(new OkHttpClient(), userAgent, listener);
    }
});