Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acquire WIFI lock too #76

Closed
bkhall opened this issue Jan 26, 2016 · 6 comments
Closed

Acquire WIFI lock too #76

bkhall opened this issue Jan 26, 2016 · 6 comments

Comments

@bkhall
Copy link

bkhall commented Jan 26, 2016

When setting wake mode, consider also getting a wifi lock if the datasource is a remote URI.

@brianwernick
Copy link
Owner

What area of the library are you talking about? EMVideoView, EMAudioPlayer, EMPlaylistService?

@bkhall
Copy link
Author

bkhall commented Jan 27, 2016

Well, in the particular app I'm writing, we are using your EMAudioPlayer to stream an mp3 icecast feed.

No to worry though, we grab our own wifi and wake locks. I was just noticing that your library has the wake lock capability too, but could possibly also use a wifi lock for remote streaming, in whatever widget it applies to.

@brianwernick
Copy link
Owner

Hmm, OK. I'll think about it some more before I give a definitive answer either way...

@bkhall
Copy link
Author

bkhall commented Jan 27, 2016

Yep, that's all my comment was meant for - something to think about.

@brianwernick
Copy link
Owner

OK. I've decided not to handle the WiFi lock in the EMAudioPlayer or EMVideoView because I don't want to worry about handling edge cases between local/web playback and keeping/releasing the locks.

However, I think that the WiFi lock should be updated in the EMPlaylistService to support locking when videos are playing as well. That said, the change probably won't make it in to ExoMedia (instead it will be in PlaylistCore once the separation is complete for the 3.0 ExoMedia release). If you are interested in an explanation for the separation see #48 (comment)

@brianwernick
Copy link
Owner

I'm going to close this as it is now out of scope on ExoMedia. I've added this to my list of things to do for PlaylistCore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants