New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adjust build targets #5
Conversation
I runned |
Hi @hanwencheng and thank you for the contribution. As said on the issue discussion, I think it would be best to leave all recent targets available (except i386 ios) and explain how to remove the deprecated ones (if needed) in the Readme
Did you run |
@@ -26,8 +27,8 @@ help: makefile | |||
## init: Install missing dependencies. | |||
.PHONY: init | |||
init: | |||
rustup target add aarch64-apple-ios armv7-apple-ios armv7s-apple-ios x86_64-apple-ios i386-apple-ios |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please split this line into the currently supported iOS targets (aarch64, x86_64) and the deprecated ones (skipping i386)? This would allow anyone with legacy plugins to still be able to fetch all targets from Rust 1.41.1
Also, I think that your PR is missing the symbolic link to x86_64 on Android (JNI) https://github.com/brickpop/flutter-rust-ffi/pull/10/files#diff-a944420e30ab791bdcdae4b59b0a627bR1 PR #10 is a duplicate of this one, but it includes the modification linked above, which is also needed. Thank you |
Merged #10 instead, since there was no response about the changes requested |
Thanks for the template and clear explaination on Medium!
This PR adjusts (adds and removes) some targets
Android
Add support for
x86_64_linux
, closes #3iOS
remove 32 bits target:
i386
,armb7s
,armv7
targetsbecause:
From 1.42.0 rust dropped 32-bit apple target support), the latest version for building ios target is 1.41.1.
In addition to that, as of Xcode 10 (10A255) - September 17, 2018, i386 architecture is no longer supported.
References of ios archs and devices could be refer here.