Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Switch tests from using httpclient to Faraday (and then future data importers can expect Faraday out-of-the-box) #19

Closed
jaredcwhite opened this issue Apr 24, 2020 · 0 comments · Fixed by #30
Labels
enhancement New feature or request process Improve the development process for the repo
Projects

Comments

@jaredcwhite
Copy link
Member

jaredcwhite commented Apr 24, 2020

Summary

I'm currently reviewing Bridgetown's plugins/hooks system and iterating towards an out-of-the-box solution for external API data import starting with REST-style calls. That let me to review what, if anything, we're currently using for an HTTP client. Currently there are some serve commands that seem to use the httpclient gem, so that's a good place to start refactoring.

Motivation

My ultimate goal is to allow folks to write tiny plugins (aka barely more than a one-liner in many cases) that will automatically provide data from external APIs to the site build (pages, templates, etc., so it's important that Bridgetown come with an opinionated default of an HTTP client plugins can standardize on. And for a variety of reasons (not least of which it's part of the standard Rails bundle), Faraday seems top of the list. The API for instantiating connections can get rather verbose, but we can easily built a thin wrapper around that which will be sufficient for "most" use cases.

@jaredcwhite jaredcwhite added this to To do in Spring 2020 via automation Apr 24, 2020
@jaredcwhite jaredcwhite added good first issue Good for newcomers enhancement New feature or request process Improve the development process for the repo and removed good first issue Good for newcomers labels Apr 24, 2020
@jaredcwhite jaredcwhite added this to the v0.13.0 "Klickitat" milestone May 1, 2020
@jaredcwhite jaredcwhite moved this from To do to In progress in Spring 2020 May 1, 2020
Spring 2020 automation moved this from In progress to Done May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request process Improve the development process for the repo
Projects
No open projects
Spring 2020
  
Done
Development

Successfully merging a pull request may close this issue.

1 participant