Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Safer #character_at #583

Closed
wants to merge 1 commit into from
Closed

Safer #character_at #583

wants to merge 1 commit into from

Conversation

srawlins
Copy link
Contributor

@srawlins srawlins commented Sep 2, 2015

Fixes #574

There might be a more specific solution, but I saw that Sass thinks these nodes have an end_pos that is on the line after the file ends. Lame.

@sds sds added the bug label Sep 4, 2015
@sds
Copy link
Owner

sds commented Sep 4, 2015

Thanks for the fix!

Merged in a998afc.

This also revealed a bug in how TrailingSemicolon handled trailing comments ending with semicolons, which I fixed in e29cc40.

@sds sds closed this Sep 4, 2015
@sds sds mentioned this pull request Sep 4, 2015
Closed
@srawlins srawlins deleted the safer-character-at branch November 6, 2015 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@srawlins @sds