Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ES5 compatibility #1

Open
kristerkari opened this issue Oct 11, 2017 · 3 comments · May be fixed by #2
Open

ES5 compatibility #1

kristerkari opened this issue Oct 11, 2017 · 3 comments · May be fixed by #2

Comments

@kristerkari
Copy link

This project is currently using ES6 Map and WeakMap. There are still quite a few browsers that don't support ES6 features used by people every day, which means that those browsers need polyfills for Map and WeakMap.

What do you think of the idea of making the code ES5 compatible, so that the polyfills can be avoided?

ping @brigand
@kristerkari
Copy link
Author

Hmm... let's try again, @brigand

@brigand
Copy link
Owner

brigand commented Oct 24, 2017

@kristerkari sorry, I missed this issue.

It does look like this code could be written without Map and WeakMap. I'd love a PR, but I won't have time to work on it in the near future. Put a note in my calendar so I don't completely forget about it.

I added a note about required polyfills to the readme for now.

@kristerkari
Copy link
Author

Good to hear 👍 I can have a look at making required changes for a PR. Thanks!

@kristerkari kristerkari linked a pull request Nov 30, 2017 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@brigand @kristerkari