Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handleFiles does not correctly handle directory creation failure #15

Open
bright-tools opened this issue Jun 10, 2015 · 0 comments
Open
Labels

Comments

@bright-tools
Copy link
Owner

in PhotoBackupService::handleFiles(), the second call to mExistingFiles.containsKey() erroneously uses bucketName as the parameter rather than bucketTargetDir and also inverts the result. This means that in the case that there is a top-level directory specified in the configuration the condition will always evaluate to true (meaning that failure to create the directory will be missed). In the case that there is no top-level directory specified, successful creation of the directory will result in an erroneous error indicating that the directory could not be created.

@bright-tools bright-tools added this to the Light Funtastic milestone Jun 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant