fix: ignore progress events #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This would be a major update since an API is being removed |
gkatsev
reviewed
Oct 3, 2018
| @@ -309,11 +304,6 @@ const initPlugin = function(player, options) { | |||
| } | |||
| }; | |||
|
|
|||
| reInitPlugin.disableProgress = function(disabled) { | |||
There was a problem hiding this comment.
this will be a breaking change. It probably should just be a no-op now.
|
Ah, didn't see your comment about this being a breaking change. I think it'll be better to just make it a no-op and make it a patch/minor release |
misteroneill
approved these changes
Oct 4, 2018
|
Tested on IE11 and Edge. LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Listening to
progressevents is redundant, this plugin already monitorstimeupdatefor playhead progress. The error dialog does not pause on open so if playback resumes the error will be cleared by the playhead moving (https://github.com/videojs/video.js/blob/master/src/js/error-display.js#L61).Specific Changes proposed
Remove the
progressevent listener so the timeout monitor does not reset.Requirements Checklist