Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

建议不要去掉全屏下返回按钮的回调 #45

Closed
jihongboo opened this issue Dec 12, 2016 · 3 comments
Closed

建议不要去掉全屏下返回按钮的回调 #45

jihongboo opened this issue Dec 12, 2016 · 3 comments

Comments

@jihongboo
Copy link
Contributor

读了你的源码，全屏模式下，返回按钮的回调去掉了，可能是为了简化操作逻辑，避免返回事件同时应用到两种播放器状态下。但对于某些页面就单独一个全屏播放器而言，返回按钮可能还要处理其他事件（比如pop vc等）。因此建议backblock可以全模式使用，并且最好能把isFullScreen参数传过来，方便区分。
@BrikerMan
Copy link
Owner

这个主意不错，稍后就改。

@jihongboo
Copy link
Contributor Author

对了，最好对block进行解包，避免block为nil 等情况

@jihongboo
Copy link
Contributor Author

我改好了，你看下Pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BrikerMan @jihongboo