Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does it support Sylius 1.3.x #26

Closed
jcgdjob opened this issue Apr 3, 2019 · 8 comments
Closed

Does it support Sylius 1.3.x #26

jcgdjob opened this issue Apr 3, 2019 · 8 comments

Comments

@jcgdjob
Copy link

jcgdjob commented Apr 3, 2019

I am on Sylius 1.3.5 and it won't allow me to install (tried also version 0.8).

@mamazu
Copy link
Collaborator

mamazu commented Apr 3, 2019

Thank you for reporting this bug. In version 0.8 it should work as it has the version constraint 1.3. But I will prepare a release of the version 0.9 which is base on sylius 1.3.x later this day.

@mamazu
Copy link
Collaborator

mamazu commented Apr 3, 2019

Version 0.9 is out.

@jcgdjob
Copy link
Author

jcgdjob commented Apr 4, 2019

Version 0.9 is out.

Thanks!

But after installation, I cannot find the "Tier price" on the menu of product variant edit. How could I fix it?

@mamazu
Copy link
Collaborator

mamazu commented Apr 4, 2019

Have you tried to update it? I have made some fixes to it.

@jcgdjob
Copy link
Author

jcgdjob commented Apr 4, 2019

Have you tried to update it? I have made some fixes to it.

Just did but still the same...
I run "php bin/console debug:container | grep tierprice"
and it's showing up.

Since I have updated ProductVariant entity before, I added the oneToMany "tierPrices" on ymal
And the class extends Brille24\SyliusTierPricePlugin\Entity\ProductVariant
I guess my changes not related to the tab menu not showing up.

Any clues?

@mamazu
Copy link
Collaborator

mamazu commented Apr 4, 2019

Have you included the service definition as defined in the README.md?

@jcgdjob
Copy link
Author

jcgdjob commented Apr 4, 2019

Have you included the service definition as defined in the README.md?

You are right. I have forgot to import
- { resource: "@Brille24SyliusTierPricePlugin/Resources/config/services.yml" }
Thanks!

Another error on js when pressing the add button.

Uncaught TypeError: table.find(...).filter(...).sortElements is not a function
    at HTMLTableCellElement.<anonymous> (itemCollectionRender.js:71)
    at Function.each (VM698 jquery-3.3.1.min.js:2)
    at w.fn.init.each (VM698 jquery-3.3.1.min.js:2)
    at tierPriceTableSort (itemCollectionRender.js:65)
    at tierPriceTableAdd (itemCollectionRender.js:10)
    at HTMLDivElement.onclick (edit:530)

Solved by adding back the sortElements js:
https://rawgit.com/padolsey/jQuery-Plugins/master/sortElements/jquery.sortElements.js

@jcgdjob jcgdjob closed this as completed Apr 4, 2019
@mamazu
Copy link
Collaborator

mamazu commented Apr 4, 2019

Glad I could help. :) Thanks for using our plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants