Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening Log Detail window causes main window to spin (commit 8636e29) #1183

Closed
philrz opened this issue Nov 3, 2020 · 1 comment · Fixed by #1196
Closed

Opening Log Detail window causes main window to spin (commit 8636e29) #1183

philrz opened this issue Nov 3, 2020 · 1 comment · Fixed by #1196
Assignees
Labels
bug Something isn't working
Milestone

Comments

@philrz
Copy link
Contributor

philrz commented Nov 3, 2020

I've narrowed down via binary search that this bug seemed to crop up at commit 8636e29 (associated with #1150, cc: @mason-fish).

Repro is with the attached hello.pcapng.zip (unzip before importing). Per the attached video, when I click on an event (such as the conn one as shown here) to bring up the Log Detail in a separate window, the main window becomes a never-ending spinner.

Repro.zip

@philrz philrz added the bug Something isn't working label Nov 3, 2020
@philrz philrz added this to the Brim v0.19.0 milestone Nov 3, 2020
@philrz philrz linked a pull request Nov 3, 2020 that will close this issue
@philrz
Copy link
Contributor Author

philrz commented Nov 7, 2020

Verified in Brim commit adba0d6.

Repeating the repro steps as shown in the attached video, now the Log Details window opens up without causing the main window to start spinning.

Verify.zip

Thanks @mason-fish!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants