-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Monaco editor doesn't load when airgapped #2915
Comments
I had this problem in a Windows 10 virtual machine The virtual machine did not have access to the Internet and the data is not loaded So the problem was not with the virtual machine, the problem was with the lack of internet in the virtual machine |
I still have this problem in a system without internet, the latest version of zui insiders has not solved this problem? |
@SoftTools59654: That is correct. The problem is still being worked on. |
@SoftTools59654: Just a heads-up that we're about to put out a GA Zui release v1.5.0 but the fix for this issue is unfortunately is not yet complete. We hope to have a fix in a Zui Insiders release soon after. Thanks for your patience. |
Is there a solution to this problem? |
@SoftTools59654: Correct, the problem has not been fixed yet. We expect to have a fix for it soon. I'll update here when the fix is verified. |
Verified in Zui commit e9f8817. In the attached video I'm using the artifact from this Actions run that's based on commit e9f8817. With my Internet disconnected, I'm now able to load data into the app and start using the editor despite being offline. Media1.mp4Thanks @jameskerr! |
@SoftTools59654: FYI, the latest GA Zui release v1.7.0 that was just posted includes this fix. |
tl;dr
When running airgapped (i.e., no Internet connection) the editor fails to load. There's Monaco-related errors in DevTools and other errors that don't show up if I repeat the same steps while Internet-connected.
Details
Repro is with GA Zui v1.4.1. I bumped into this while trying to reproduce a problem reported in a community Slack thread.
In the attached video I'm launching Zui fresh after having just installed it and while having no working Internet connectivity.
While the mere launch of the app seems healthy, I do see some errors in DevTools right out of the gate, and I don't see those same errors if I launch when Internet-connected. They may be unrelated to the editor problem, but I figured I'd point them out regardless if we want to better understand their origin and maybe catch/silence these in some way.
The more concerning problem is after I load some data and the editor area is populated with text that just says "Loading..." The DevTools console shows errors related to Monaco, among others.
Media1.mp4
If there's some reason why we simply need Internet connectivity for the app to work, we'd certainly be free to set that expectation with users, but ideally we'd want to fail gracefully in a situation like this so the user is informed what's wrong.
The text was updated successfully, but these errors were encountered: