Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate ComposerPackageVersion from silverstripe-composer-versions module #46

Closed
robbieaverill opened this issue May 16, 2018 · 0 comments · Fixed by #49
Closed

Migrate ComposerPackageVersion from silverstripe-composer-versions module #46

robbieaverill opened this issue May 16, 2018 · 0 comments · Fixed by #49
Labels
affects/v4 complexity/low impact/low type/enhancement

Comments

@robbieaverill
Copy link
Contributor

robbieaverill commented May 16, 2018 •
edited

The ComposerPackageVersion DataObject is "a DataObject to allow saving the information in the db to use the information in various ways".

We should move this DataObject into the silverstripe-maintenance module. The silverstripe-composer-versions module purely provides this DataObject, so could comfortably be merged into this main repository.

This would mean that the other modules, e.g. silverstripe-composer-update-checker, would be able to provide additional value via a DataExtension on this object (see bringyourownideas/silverstripe-composer-update-checker#25)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects/v4 complexity/low impact/low type/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pulls/1.0/refactor creative-commoners/silverstripe-maintenance
1 participant
@robbieaverill