Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup not opening #105

Closed
erperejildo opened this issue Nov 16, 2023 · 8 comments
Closed

Popup not opening #105

erperejildo opened this issue Nov 16, 2023 · 8 comments

Comments

@erperejildo
Copy link

I'm testing on Android emulator and real phone. The app is already published in Google Play.

code:

onTap: () async {
                final InAppReview inAppReview = InAppReview.instance;
                if (await inAppReview.isAvailable()) {
                  inAppReview.requestReview();
                }
              },

logs:

I/InAppReviewPlugin(12698): onMethodCall: isAvailable
I/InAppReviewPlugin(12698): isAvailable: called
I/InAppReviewPlugin(12698): noContextOrActivity: called
I/InAppReviewPlugin(12698): isAvailable: playStoreAndPlayServicesAvailable: true
I/InAppReviewPlugin(12698): isAvailable: lollipopOrLater: true
I/InAppReviewPlugin(12698): isAvailable: Play Store, Play Services and Android version requirements met
I/InAppReviewPlugin(12698): cacheReviewInfo: called
I/InAppReviewPlugin(12698): noContextOrActivity: called
I/PlayCore(12698): UID: [10147]  PID: [12698] ReviewService : requestInAppReview (com.drodriguez.time_tap)
I/InAppReviewPlugin(12698): cacheReviewInfo: Requesting review flow
I/PlayCore(12698): UID: [10147]  PID: [12698] ReviewService : Initiate binding to the service.

Documentation:

Android
Opens In App Review but only if Play Services are installed on the device and the App is downloaded through the Play Store. Check out the official documentation.

@britannio
Copy link
Owner

Hey, did you install the app via the play store to test this?

@erperejildo
Copy link
Author

Hey, did you install the app via the play store to test this?

No, I have it published (https://play.google.com/store/apps/details?id=com.drodriguez.time_tap) but I'm testing locally. You mean I need to deploy this wihtout testing it and try directly from production app? Because if so, I don't find it safe TBH. I could try anyway, I don't have any users, but I won't be able to test it locally at all?

@erperejildo
Copy link
Author

I just tried with the Google Play version (you can test it yourself from that link above) and it doesn't work

@britannio
Copy link
Owner

image
Works for me. Also, I would suggest that you follow the guidelines (https://pub.dev/packages/in_app_review#guidelines) and use openStoreListing() when the "Write a review" button is pressed.

@erperejildo
Copy link
Author

erperejildo commented Nov 20, 2023

openStoreListing

For me, it doesn't work at all.

How do I detect if the user didn't open to redirect them to Google Play with that? Or do you mean replacing what I have completely? Because if so, I could simply open a link

@britannio
Copy link
Owner

openStoreListing

For me, it doesn't work at all.

How do I detect if the user didn't open to redirect them to Google Play with that? Or do you mean replacing what I have completely? Because if so, I could simply open a link

Or do you mean replacing what I have completely?

Yes, and using a link is completely fine if you wish. The format can be found at https://github.com/britannio/in_app_review/blob/master/in_app_review/android/src/main/java/dev/britannio/in_app_review/InAppReviewPlugin.java#L209

@erperejildo
Copy link
Author

I'll use that. Feel free to close or not the issue

@britannio
Copy link
Owner

Cool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants