Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update genres in data.js file to be uniform #338

Open
3 tasks
brittanyrw opened this issue Oct 8, 2019 · 3 comments
Open
3 tasks

Update genres in data.js file to be uniform #338

brittanyrw opened this issue Oct 8, 2019 · 3 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed javascript Update requires adding or modifying JavaScript

Comments

@brittanyrw
Copy link
Owner

In the data.js file there are a lot of variations of the same genre. For example, R&B has: r&b, rb, R&B, r-n-b. These should all be r&b.

Update the genres in the data.js file to make sure they are all uniform. All the genres should match a genre in this file: https://github.com/brittanyrw/emojibops/blob/master/genres.md

If a genre is not listed in this file and is included in the data.js file, please delete the genre. Try to replace those genres with one from the data.js file if possible. For example, if alternative-rock is in the data.js file, replace it with rock.

Suggested to do list:

  • Remove genres that are not listed in genres.md or replace them with something close.
  • Make sure all genres are lowercase with no spaces (use a hyphen instead of a space)
  • Make sure all songs have at least one genre.
@brittanyrw brittanyrw added enhancement New feature or request help wanted Extra attention is needed javascript Update requires adding or modifying JavaScript labels Oct 8, 2019
@dwjohnston93
Copy link

Hello Brittany, can I work on this issue?

@brittanyrw
Copy link
Owner Author

@dwjohnston93 Sure, I will assign this to you!

@jaas666
Copy link

jaas666 commented May 15, 2022

This issue has an open PR #341

Can someone review the PR or update/close the Issue if the requirements changed or is no longer applicable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed javascript Update requires adding or modifying JavaScript
Projects
None yet
Development

No branches or pull requests

3 participants