Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Same customerID assigned for anonymous purchase followed by registration. #22

Closed
jskorton opened this issue Sep 9, 2013 · 2 comments
Closed

Comments

@jskorton
Copy link
Contributor

jskorton commented Sep 9, 2013

I am not sure if this is a bug, but I thought it was worth noting.

If you start fresh on the demo site and first buy something anonymously then register you can see the purchase in your view order history. The email address of the purchase can be different from the email address of the registration so long as the sequences of events takes place in the same session.

The use case in which I imagined this to be a bug is when a customer would buy an item anonymously then leave the computer and another person would register using the same web browser. The second person could then see the first person's order in their history.

@apazzolini
Copy link
Contributor

This is occurring because we don't expire sessions after checkout, so if a user registers immediately after buying something, we'll convert their current session to a registered one (which would then link the order they just created).

I'm on the fence about this being a bug, I can see both sides being valid. We might want to consider providing a property that would control this behavior, session.expireAfterCheckout

@bpolster
Copy link
Member

I think the property is the right answer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants