Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite PassthroughSubject, CurrentValueSubject and Future #170

Merged
merged 5 commits into from Jun 25, 2020

Conversation

broadwaylamb
Copy link
Member

@broadwaylamb broadwaylamb commented Jun 25, 2020

This PR introduces a more correct and efficient implementation for these.

No more leaking subscriptions!

@broadwaylamb broadwaylamb added the bug Something isn't working label Jun 25, 2020
@broadwaylamb broadwaylamb added this to In progress in OpenCombine via automation Jun 25, 2020
@codecov
Copy link

codecov bot commented Jun 25, 2020

Codecov Report

Merging #170 into master will decrease coverage by 0.21%.
The diff coverage is 95.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #170      +/-   ##
==========================================
- Coverage   98.10%   97.89%   -0.22%     
==========================================
  Files          86       87       +1     
  Lines        5290     5550     +260     
==========================================
+ Hits         5190     5433     +243     
- Misses        100      117      +17     
Impacted Files Coverage Δ
Sources/OpenCombine/Helpers/ConduitBase.swift 38.46% <38.46%> (ø)
Sources/OpenCombine/Future.swift 96.69% <96.61%> (-3.31%) ⬇️
Sources/OpenCombine/Helpers/ConduitList.swift 96.66% <96.66%> (ø)
Sources/OpenCombine/PassthroughSubject.swift 97.72% <97.60%> (-0.58%) ⬇️
Sources/OpenCombine/CurrentValueSubject.swift 97.90% <97.77%> (-0.63%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b34d465...30be07a. Read the comment docs.

@OpenCombineBot
Copy link

OpenCombineBot commented Jun 25, 2020

LGTM

Generated by 🚫 Danger Swift against 30be07a

@broadwaylamb broadwaylamb merged commit 70bf8e8 into master Jun 25, 2020
OpenCombine automation moved this from In progress to Done Jun 25, 2020
@broadwaylamb broadwaylamb deleted the subjects-revamp branch June 25, 2020 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
OpenCombine
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants