Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kirby Package Manager and gitignore #34

Closed
illycz opened this issue Jan 31, 2018 · 5 comments
Closed

Kirby Package Manager and gitignore #34

illycz opened this issue Jan 31, 2018 · 5 comments

Comments

@illycz
Copy link

illycz commented Jan 31, 2018

Would it be possible to add plugins to .gitignore configurable?
I don't think everyone is using CI.

What do you think?

@pqml
Copy link
Member

pqml commented Feb 1, 2018

Not sure to understand what you want

A lot of features are missing from Kirby Package Manager

  • We really need to add some kind of version control (possibly based on git hash because a lot of kirby plugins don't make releases or don't update package.json version number)
  • We also need an unlink feature to simply download a plugin without putting it in the .gitignore. I have to do this manually on projects using CI to avoid breaking them if a plugin makes breaking changes

We made a repo to move kirby package manager outside the kirby webpack boilerplate but didn't start to work on it
https://github.com/brocessing/kirby-package-manager

@illycz
Copy link
Author

illycz commented Feb 1, 2018

I meant the option to cancel adding plugin to .gitignore when I use Kirby Package Manager...

@arnaudjuracek
Copy link
Member

So what you're proposing is something along the line of npm run kirby:add --no-gitignore ?

@illycz
Copy link
Author

illycz commented Feb 1, 2018

Yes or Kirby option in config file...

@arnaudjuracek
Copy link
Member

Commit 72a4e07 adds the --no-ignore flag to kirby:add

Upgrade to 0.7.3 to be able to run :

$ yarn kirby:add --no-ignore
$ npm run kirby:add -- --no-ignore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants