Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Add -x option to exclude values #49

Merged
merged 1 commit into from Feb 8, 2022

Conversation

idanski
Copy link
Contributor

@idanski idanski commented Feb 8, 2022

Hey, this was useful for me so I opened this PR.

-x (eXclude values) enabled --dump-all and remove specified values.

I tested it locally and it works fine for me. Attaching a picture of the help.
image

@bomgar
Copy link
Member

bomgar commented Feb 8, 2022

Hi. Could you add conflicts_with to the clap definition. I guess -x and -a should not be used at the same time.
The build is red because of formatting so I guess cargo fmt should fix it.

@idanski
Copy link
Contributor Author

idanski commented Feb 8, 2022

Hi. Could you add conflicts_with to the clap definition. I guess -x and -a should not be used at the same time. The build is red because of formatting so I guess cargo fmt should fix it.

That was quick! Thanks, I added the conflicts_with for -x and applied formatting.

@bomgar bomgar merged commit 0d6dc62 into brocode:master Feb 8, 2022
@idanski idanski deleted the add_exclude_values branch February 8, 2022 16:07
@bomgar
Copy link
Member

bomgar commented Feb 8, 2022

released

@idanski
Copy link
Contributor Author

idanski commented Feb 8, 2022

@bomgar can I help release it to brew? my team will be happy to have it 😃
I saw it here:
https://github.com/Homebrew/homebrew-core/blob/HEAD/Formula/fblog.rb

is it just a matter of updating the release url and the first sha256? or is there more to it?

@bomgar
Copy link
Member

bomgar commented Feb 8, 2022

Oh i didn't know it was added to core. There is a formula in this repo here: https://github.com/brocode/fblog/tree/master/Formula

I don't own a Mac so I can't help you with that. My guess is that the url and checksums should be enough. As far as I know you can execute formulas locally to test everything.

If it is part of central I should probably delete the formula here 🤔

@idanski
Copy link
Contributor Author

idanski commented Feb 8, 2022

seems like it is, as brew install fblog returns fblog 3.1.2, so it's probably save to delete the formula here.

I'll see if I can bump the version myself.

Thanks again for you help :)

@idanski
Copy link
Contributor Author

idanski commented Feb 8, 2022

Tested locally and opened a PR for core.
Homebrew/homebrew-core#94722

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants