Update deps, including clap to v4

[chevdor]

This PR makes #234 obsolete.

It bumps clap to v4. Clap v3 is now maintenance only.

Noticeable: for now using clap v4 means there is no more colored help. This is however likely to change in the future and there should be ways to reintroduce coloring if wanted.

NOTE: During the conversion from .takes_value(true) => num_args(...) I used a blanket range num_args(1..) which may be refined in some cases.

[bomgar]

.num_args(0) does not work as expected for me. I did the migration brocode/fblog#65 just a few minutes ago and I had to change all the flags.

.action(ArgAction::SetTrue)

[chevdor]

Yes, I was about to update with a DO NOT MERGE YET, I am spotting issues.

[chevdor]

I fixed a bunch of issues but some probably remain and some testing is required.
I am switching my "default" to the binary produced here to see if I ran into problems.. but this is not exhaustive testing :)

[chevdor]

The existing tests do pass though:

Compiling fw v2.16.1 (/Users/Shared/projects/fw)
    Finished test [unoptimized + debuginfo] target(s) in 1.45s
    Starting 18 tests across 1 binaries
        PASS [   0.032s] fw::bin/fw config::path::tests::test_do_expand_path
        PASS [   0.034s] fw::bin/fw config::tests::test_after_clone_from_tags_missing_all_tags_graceful
        PASS [   0.037s] fw::bin/fw config::path::tests::test_do_not_expand_path_without_tilde
        PASS [   0.038s] fw::bin/fw config::tests::test_after_clone_from_tags
        PASS [   0.037s] fw::bin/fw config::tests::test_after_clone_from_tags_prioritized
        PASS [   0.037s] fw::bin/fw config::tests::test_after_clone_override_from_project
        PASS [   0.037s] fw::bin/fw config::tests::test_workon_from_tags_missing_one_tag_graceful
        PASS [   0.041s] fw::bin/fw config::tests::test_workon_from_tags_missing_all_tags_graceful
        PASS [   0.042s] fw::bin/fw config::tests::test_workon_from_tags
        PASS [   0.045s] fw::bin/fw config::tests::test_after_clone_from_tags_missing_one_tag_graceful
        PASS [   0.055s] fw::bin/fw config::tests::test_workon_from_tags_prioritized
        PASS [   0.057s] fw::bin/fw git::tests::test_repo_name_from_ssh_pragma
        PASS [   0.056s] fw::bin/fw git::tests::test_repo_name_from_ssh_pragma_with_multiple_git_endings
        PASS [   0.058s] fw::bin/fw config::tests::test_workon_override_from_project
        PASS [   0.056s] fw::bin/fw git::tests::test_repo_name_from_url
        PASS [   0.058s] fw::bin/fw projectile::tests::test_replace_path_with_tilde
        PASS [   0.060s] fw::bin/fw projectile::tests::test_persists_projectile_config
        PASS [   0.067s] fw::bin/fw git::tests::test_username_from_git_url
------------
     Summary [   0.081s] 18 tests run: 18 passed, 0 skipped

[chevdor]

I still run into issues, so this is not mergeable yet but I will need to jump on other duties.
I think you can commit into my branch, feel free to do so if you spot some of the issues.

[icepuma]

Looks like a duplicate

[icepuma]

All occurrences of num_args(1..) including this one should be replaced by num_args(1) I guess.

[bomgar]

I merged this to master but I will not release it yet. I will test this for a while on my machine

[chevdor]

Awesome, I will also install master locally and use it "in prod" then.

[bomgar]

I already had to push a few fixes :(

[chevdor]

It does NOT look too good on my end: workon gives me an empty list.
EDIT: Juts seen your comment above 👌

[chevdor]

I already had to push a few fixes :(

I rebuilt and indeed, your latest looks much better.