Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set workspace in tag/project #27

Closed
mriehl opened this issue Apr 28, 2017 · 2 comments
Closed

Set workspace in tag/project #27

mriehl opened this issue Apr 28, 2017 · 2 comments
Assignees
Projects

Comments

@mriehl
Copy link
Member

mriehl commented Apr 28, 2017

This would allow us to drop override_path entirely. It would also be possible to set the workspace location depending on the tag type (e.G. golang wants projects in $GOPATH/src/github.com/subject/repo) or e.G. projects from "work" in a separate workspace etc.

This would also simplify path computation (always join workspace and project name). I guess if we do this we should also ensure project names are unique across the board (there is already some infrastructure to check project sanity that is performed on load/save).

@bomgar thoughts?

@mriehl mriehl added this to TODO in fw Apr 28, 2017
@mriehl mriehl moved this from TODO to Needs discussing in fw Apr 28, 2017
@mriehl
Copy link
Member Author

mriehl commented Apr 30, 2017

There is also the question of what happens if multiple tags try to set the workspace. Last one wins (highest value for priority) seems like it would be what is expected in most cases but it could also be a configuration error, I don't know

@mriehl mriehl closed this as completed May 5, 2017
@mriehl
Copy link
Member Author

mriehl commented May 5, 2017

I implemented last one wins (higher priority since this is supposedly the most specific)

@mriehl mriehl moved this from Needs discussing to Review in fw May 5, 2017
@bomgar bomgar moved this from Review to Done in fw May 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
fw
Done
Development

No branches or pull requests

2 participants