Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support https repositories with auth token #85

Closed
megamorf opened this issue Jan 24, 2019 · 8 comments
Closed

support https repositories with auth token #85

megamorf opened this issue Jan 24, 2019 · 8 comments

Comments

@megamorf
Copy link

In your sample config you list Github and Gitlab Tokens:

https://github.com/brocode/fw/blob/master/doc/sample_config.json#L24
https://github.com/brocode/fw/blob/master/doc/sample_config.json#L27

What are they used for? I added them to my config but could not clone repositories that way.

Thanks in advance :-)

@megamorf
Copy link
Author

I can see that the use case is to import an organisation's repos: #47
So for everything else an ssh-agent and non-HTTPS repos are required still, right?

@mriehl
Copy link
Member

mriehl commented Jan 25, 2019

Yeah exactly!

@mriehl
Copy link
Member

mriehl commented Jan 25, 2019

For pull/clone I think we could support push tokens eG over https even with two factor auth setup. Is this something that would help you?

@megamorf
Copy link
Author

I'd love to be able to pull https repositories with access token authentication .That would make the fw configuration a lot more portable.

@bomgar bomgar changed the title Question about access token settings https repositories with auth token Jan 25, 2019
@bomgar bomgar changed the title https repositories with auth token support https repositories with auth token Jan 25, 2019
@bomgar
Copy link
Member

bomgar commented Jan 25, 2019

@megamorf are you interested in implementing this yourself?

@megamorf
Copy link
Author

@bomgar Yesterday was the first time that I had the chance to look at Rust source code, i.e. my rust skills are almost non-existent. I 'd suggest letting others give feedback to gauge the interest in the feature.

@bomgar
Copy link
Member

bomgar commented Jan 28, 2019

@megamorf We discussed how to implement this and noticed it is already possible (Although not as nice as it could be)
But at the moment you could use https://bomgar:token@github.com/21re/secure-repo.git as git URL. This has some security drawbacks but works just fine.
We are not sure yet how we should improve on this. Any suggestions?

@megamorf
Copy link
Author

@bomgar I understand where you are coming from, but I have around 170 repos in ~/projects" and if I use the fw init` I'd have to manually change each fw project's git property in the config (depending on the repo's remote origin url/protocol), right?

One possible solution would be to be able to make username/token a per project setting that can be populated by using the tags system. That way you could have multiple credentials that you can assign to certain projects (that would require the project url to be based on HTTP(s) though).

@megamorf megamorf closed this as completed Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants