Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attribute Order Shouldn't Matter #93

Closed
brodieG opened this issue Mar 23, 2018 · 0 comments
Closed

Attribute Order Shouldn't Matter #93

brodieG opened this issue Mar 23, 2018 · 0 comments
Labels
Milestone

Comments

@brodieG
Copy link
Owner

brodieG commented Mar 23, 2018

Currently, if more than one attribute is missing or wrong, which attribute is reported as problematic depends on the order the attribute shows up in the attribute pair list.

    > Recent bug fixes in the development version of R,
    > "R-devel",   (see the short thread starting here:  
    > https://stat.ethz.ch/pipermail/r-devel/2018-March/075644.html
    > ) have lead your packages to no longer pass  'R CMD
    > check'  with that version of R-devel:

    >  https://www.r-project.org/web/checks/check_results_nima.html
    > https://www.r-project.org/web/checks/check_results_vetr.html

    > In both cases, the reason is a *too strict* test, you not
    > only check that the attributes (of a certain data frame)
    > are correct, but you *wrongly* also check that the list
    > which attributes(<df>) returns has the attributes in a
    > given order.

    > Instead please fix your check e.g., to use identical() if
    > appropriate, because even identical() with its default
    > argument 'attr.as.set = TRUE'  does *not* distinguish
    > objects where only the attributes are re-ordered.

    > Best regards,

    > Martin Maechler ETH Zurich  and  R Core Team
@brodieG brodieG added the bug label Mar 23, 2018
@brodieG brodieG added this to the 0.2.4 milestone Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant