[prettierX] better class & function formatting options

[brodybits]

From prettier/prettier#10018 I am thinking it would be a nice solution to always put the opening brace ({) on its own line. This would be "solution 2" in prettier/prettier#10018 but for all ES classes. For example:

class SimpleClass
{
  method1() {}
  method2() {}

  method3() {}
}

class HigherLevelClassWithLongNameAndExtendedFunctionality
  extends SuperMajorBaseClassWithHeavyFunctionality
  implements SuperLargeGenericInterface
{
  method1() {}
  method2() {}

  method3() {}
}

I think this would be better than the request in prettier/prettier#4870 to "respect/enforce" line break after class declaration.

[ristomatti]

One option I haven't seen mentioned would be to use double indent for a multi line class (or function) definition. This would be the most preferable to me and I believe it's an option in JetBrains IDE's also.

class HigherLevelClassWithLongNameAndExtendedFunctionality
    extends SuperMajorBaseClassWithHeavyFunctionality
    implements SuperLargeGenericInterface {
  method1() {}
  method2() {}

  method3() {}
}

This would work also for long constructor/method/function parameters.

Input:

function someVeryLongName(param1: QuiteLongType, param2: AnotherLongType, param3: string) {
  doSomeThing();
} 

Current output:

function someVeryLongName(
  param1: QuiteLongType,
  param2: AnotherLongType,
  param3: string) {
  doSomeThing();
} 

Suggested output:

function someVeryLongName(
    param1: QuiteLongType,
    param2: AnotherLongType,
    param3: string) {
  doSomeThing();
} 

Edit: Added missing commas and semicolons.

[brodybits]

use double indent for a multi line class (or function) definition

My apologies for the delay, definitely looks like a nice option.

class HigherLevelClassWithLongNameAndExtendedFunctionality
    extends SuperMajorBaseClassWithHeavyFunctionality
    implements SuperLargeGenericInterface {
  method1() {}
  method2() {}

  method3() {}
}

Here is how Prettier 2.3.2 & prettierX 0.19.0 would currently format it:

Prettier 2.3.2
Playground link

--parser babel

Input:

class HigherLevelClassWithLongNameAndExtendedFunctionality
    extends SuperMajorBaseClassWithHeavyFunctionality
    implements SuperLargeGenericInterface {
  method1() {}
  method2() {}

  method3() {}
}

Output:

class HigherLevelClassWithLongNameAndExtendedFunctionality
  extends SuperMajorBaseClassWithHeavyFunctionality
  implements SuperLargeGenericInterface
{
  method1() {}
  method2() {}

  method3() {}
}

This would work also for long constructor/method/function parameters.

👍

[brodybits]

This would work also for long constructor/method/function parameters.

👍

Input:

function someVeryLongName(param1: QuiteLongType, param2: AnotherLongType, param3: string) {
  doSomeThing();
} 

Current formatting behavior by Prettier 2.3.2 / prettierX 0.19.0 (don't think which parser will make a difference here):

Prettier 2.3.2
Playground link

--parser babel

Input:

function someVeryLongName(param1: QuiteLongType, param2: AnotherLongType, param3: string) {
  doSomeThing();
} 

Output:

function someVeryLongName(
  param1: QuiteLongType,
  param2: AnotherLongType,
  param3: string
) {
  doSomeThing();
}

Suggested output:

function someVeryLongName(
    param1: QuiteLongType,
    param2: AnotherLongType,
    param3: string) {
  doSomeThing();
} 

That would definitely be more compact.

Edit: Added missing commas and semicolons.

Thanks for the edits