Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parent is required when editing in Netlify CMS #14

Closed
zairja opened this issue Dec 18, 2020 · 1 comment
Closed

Parent is required when editing in Netlify CMS #14

zairja opened this issue Dec 18, 2020 · 1 comment

Comments

@zairja
Copy link
Contributor

zairja commented Dec 18, 2020

Describe the bug
When trying to publish a page with top-level navigation, the parent field is required when publishing via Netlify CMS, preventing it from getting published/saved.

To Reproduce
Steps to reproduce the behavior:

  1. While logged into the Netlify CMS, edit a top-level page or create a new page that will not have a parent.
  2. Click on the 'Publish' button in the top-right corner.
  3. See input validation that a parent is required, preventing the page from being published.

Expected behavior
The parent field should be optional. When no parent is provided, the eleventyNavigation parent property should not be present at all in the .md file (this is the case with existing top-level pages like "Getting Started").

Screenshots
image

I can attempt a fix and create a PR if this is not a priority since it is a big hassle with some of my current projects. Thank you for your work!

@broeker
Copy link
Owner

broeker commented Dec 19, 2020

Awesome thanks for catching -- this should new be fixed in main branch, feel free to re-open if not.

@broeker broeker closed this as completed Dec 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants