Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

32 Bit Overflow for Rev-DNS #14

Closed
brompwnie opened this issue Mar 5, 2020 · 1 comment
Closed

32 Bit Overflow for Rev-DNS #14

brompwnie opened this issue Mar 5, 2020 · 1 comment
Assignees
@brompwnie
Labels
bug Something isn't working

Comments

@brompwnie
Copy link
Owner

The rev-dns function contains an overflow for 32bit builds due to the constant 4278190080.
This can be reproduced by running the provided makefile

make
>> removing previous builds
>> running check for unused/missing packages in go.mod
>> building Linux 64bit binary
GOOS=linux GOARCH=amd64 go build -o /github.com/brompwnie/botb/bin/botb-linux-amd64 ./
>> running check for unused/missing packages in go.mod
>> building darwin 64bit binary
GOOS=darwin GOARCH=amd64 go build -o /github.com/brompwnie/botb/bin/botb-darwin-amd64 ./
>> running check for unused/missing packages in go.mod
>> building linux 32bit binary
GOOS=linux GOARCH=386 go build -o /github.com/brompwnie/botb/bin/botb-linux-386 ./
# github.com/brompwnie/botb
./utils.go:1079:37: constant 4278190080 overflows int
make: *** [build-linux32] Error 2
@brompwnie brompwnie self-assigned this Mar 5, 2020
@brompwnie brompwnie added the bug Something isn't working label Mar 5, 2020
@NodyHub NodyHub mentioned this issue Mar 5, 2020
Merged
@brompwnie
Copy link
Owner Author

Closing this issue, it's resolved 🎆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brompwnie brompwnie

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brompwnie