Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved CLI #244

Merged
merged 3 commits into from Jan 15, 2021
Merged

Improved CLI #244

merged 3 commits into from Jan 15, 2021

Conversation

Yash-Singh1
Copy link
Contributor

### If you have an issue with a specific extension or type

Locate the definition for your extension/type in the db.json file in the mime-db project. Does it look right?

- [ ] No. File a mime-db issue.
- [ ] Yes: Go ahead and submit your issue/PR here and I'll look into it.

This Pull Request is related to the CLI

I added in the version flag, the help flag, and the name flag with a few improvements to the CLI.

@broofa
Copy link
Owner

broofa commented Jan 15, 2021

This looks good, thanks! Merging, but I'm going to hold off on publishing this until I've had a chance to add tests for the CLI, to make sure this runs on the supported node versions.

@broofa broofa merged commit 05a6a02 into broofa:master Jan 15, 2021
@broofa broofa mentioned this pull request Jan 16, 2021
broofa pushed a commit that referenced this pull request Jan 16, 2021
* Added in version flag and name flag

* Improved CLI
@broofa
Copy link
Owner

broofa commented Jan 16, 2021

Published as mime@2.5.0

Repository owner deleted a comment Mar 10, 2021
Repository owner deleted a comment Mar 10, 2021
Repository owner locked and limited conversation to collaborators Mar 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants