Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collaborators #88

Closed
jonathanong opened this issue Apr 25, 2014 · 2 comments
Closed

collaborators #88

jonathanong opened this issue Apr 25, 2014 · 2 comments

Comments

@jonathanong
Copy link

there are a bunch of mime types i want to add as well as features. for now, i just created https://github.com/expressjs/mime-extended instead of bothering making PRs.

do you want to share maintenance? you could add me as a collaborator or i can add you to the expressjs org and you can move this repo to the organization. this library is pretty much used everywhere in node, so it would be nice if there were more collaborators.

this module would play very nicely with a lot of mime-related utilities in the organization like https://github.com/expressjs/compressible

@jonathanong jonathanong changed the title more mime types collaborators Apr 25, 2014
@broofa
Copy link
Owner

broofa commented Apr 25, 2014

Types used by express core are probably of universal enough interest to warrant adding them to node.types in this project.

I'm not sure about the contentType method. 'Kind of thinking that might be best left out of the core API, but not 100% sure. However I do think globally extending the mime API is bad practice if it can be avoided. It's going to lead to confusion over what methods are actually part of mime .vs. what aren't. And lead to breakage of code that depends on the express version of the mime API, when that code is pulled into non-express projects.

@jonathanong
Copy link
Author

okay moved the content type stuff to here: https://github.com/expressjs/set-type

what about the other types? there are PRs about them that are still open. don't really want to create more unless you merge them or just add me as a collab/move to expressjs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants