Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding select flag information to stg_dbt__run_results #91

Closed
LukasSandm opened this issue Feb 22, 2022 · 2 comments
Closed

Adding select flag information to stg_dbt__run_results #91

LukasSandm opened this issue Feb 22, 2022 · 2 comments

Comments

@LukasSandm
Copy link

stg_dbt__run_results show models args as selected_models column, but since moving to dbt1, the models flag has been deprecated and the select flag is being used instead. It would be great to have the information from the select flag available in the model.

An example implementation could be replacing this line:
https://github.com/brooklyn-data/dbt_artifacts/blob/main/models/staging/stg_dbt__run_results.sql#L36

by something like the following code:

coalesce(data:args:models, data:args:select) as selected_models,

to account for projects transitioning from dbt prior to dbt1 to dbt1.

@LukasSandm
Copy link
Author

If you see above as valid and valuable update to the package, I would also be open to contribute directly to the package and open a PR for it.

@alanmcruickshank
Copy link
Contributor

I think this would be a great contribution @LukasSandm . Could you put together a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants