Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Entry Sensor on T8030 never emits event #314

Closed
Palmke opened this issue Mar 17, 2023 · 1 comment
Closed

[Bug]: Entry Sensor on T8030 never emits event #314

Palmke opened this issue Mar 17, 2023 · 1 comment
Labels
bug Something isn't working fixed

Comments

@Palmke
Copy link
Contributor

Palmke commented Mar 17, 2023

Client version

2.4.2

Node version

v16.19.1

Operating System type

Linux

Operating system version

Raspberry OS

Describe the bug

An entry sensor T8900 never emits an open/close event when it is connected to a Homebase 3.
This is seen here: https://github.com/bropat/eufy-security-client/blob/master/src/push/service.ts#L346

This line is missing from the if-statement:
normalized_message.sensor_open = push_data.e !== undefined ? push_data.e === "1" ? true : false : undefined;
The field e is also missing from the data type (PlatformPushMode) the push data is cast to.

The fix seems trivial, but I wonder why this explicit if-statement was introduced for the T8030.
Can the push handling not just be handled by the already existing code, @bropat ?

To reproduce

View logs

Screenshots & Logfiles

No response

Additional context

No response

@Palmke Palmke added the bug Something isn't working label Mar 17, 2023
@martijnpoppen
Copy link
Contributor

@Palmke See: #319

@bropat bropat added the fixed label Apr 11, 2023
@bropat bropat closed this as completed Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed
Projects
None yet
Development

No branches or pull requests

3 participants