Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Support 2FA #1

Closed
ubieberich opened this issue Oct 5, 2020 · 7 comments
Closed

Feature request: Support 2FA #1

ubieberich opened this issue Oct 5, 2020 · 7 comments
Assignees
Labels
enhancement New feature or request implemented

Comments

@ubieberich
Copy link

Describe the bug
My eufy account has 2FA activated. The adapter only provides fields für User and password.

Screenshots & Logfiles
log.log

Versions:

  • Adapter version: 0.0.1
  • JS-Controller version: 3.1.6
  • Node version: 12.18.3
  • Operating system: linux (Doker)
@bropat
Copy link
Owner

bropat commented Oct 23, 2020

Hi ubieberich,

2FA is almost implemented. The login is already working as well as trusting ioBroker as "Trusted Device". I'm currently working on the token renewal.
As soon as it is stable enough i will release it.

@bropat bropat self-assigned this Oct 23, 2020
@bropat bropat added the enhancement New feature or request label Oct 23, 2020
@bropat
Copy link
Owner

bropat commented Nov 1, 2020

Hi ubieberich,

2FA is almost implemented. The login is already working as well as trusting ioBroker as "Trusted Device". I'm currently working on the token renewal.
As soon as it is stable enough i will release it.

In the meantime the push notifications aren't working anymore. The push notifications are the only way I have found to renew the token without human intervention.
I'm investigating the issue with @JanLoebel here.

@bropat
Copy link
Owner

bropat commented Nov 16, 2020

@ubieberich 2FA is supported with version 0.0.2, but it still misses the renewal of the authentication token. This means that when the authentication token expires the verification code will be sent again and it must be entered again in the adapter to continue wo work.

@linuxq
Copy link

linuxq commented Nov 16, 2020 via email

@bropat
Copy link
Owner

bropat commented Nov 16, 2020

@linuxq Version 0.0.2 isn't released. It will be published in the next days.

@bropat
Copy link
Owner

bropat commented Nov 21, 2020

Version 0.0.2 with 2FA support was published.

Note: After successful authentication the token expires after 1 month and the renewal process is not implemented, so manual intervention is required!

@bropat bropat added the work in progress Working on it label Dec 3, 2020
@ubieberich
Copy link
Author

Adapter works fine for me. No problem with the first 2FA login. Great job. Thanks.

Waiting till the token expires. Will then test the manual re-login.

@bropat bropat changed the title 2FA not supported Feature request: Support 2FA Dec 14, 2020
bropat pushed a commit that referenced this issue Dec 22, 2020
* Little progress for feature request: [#5](#5)
* Implemented set Guard Mode with CMD_SET_PAYLOAD for certain devices
* Added back USA ip addresses for P2P cloud discovery
* Using the correct local time zone for communication with the Eufy Cloud
* HUB filtering by device type 0 (station) removed
* Added documentation for 2FA
* Updated versions of the package dependencies
bropat pushed a commit that referenced this issue Dec 22, 2020
* Little progress for feature request: #5
* Implemented set Guard Mode with CMD_SET_PAYLOAD for certain devices
* Added back USA ip addresses for P2P cloud discovery
* Using the correct local time zone for communication with the Eufy Cloud
* HUB filtering by device type 0 (station) removed
* Added documentation for 2FA
* Updated versions of the package dependencies
@bropat bropat closed this as completed Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request implemented
Projects
None yet
Development

No branches or pull requests

3 participants