Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid webhook list name causes exception #19

Closed
brotskydotcom opened this issue Jul 31, 2020 · 1 comment
Closed

Invalid webhook list name causes exception #19

brotskydotcom opened this issue Jul 31, 2020 · 1 comment
Assignees
Labels
bug Something isn't working duplicate This issue or pull request already exists
Milestone

Comments

@brotskydotcom
Copy link
Owner

Found these lines in the running server log:

Jul 29 12:31:11 bdc-public-services app/web.1 Processing webhook items on 'None'...
Jul 29 12:31:11 bdc-public-services app/web.1 Task exception was never retrieved
Jul 29 12:31:11 bdc-public-services app/web.1 future: <Task finished name='Task-393' coro=<transfer_all_webhook_items() done, defined at /app/app/workers/webhook_transfer.py:114> exception=AttributeError("'NoneType' object has no attribute 'split'")>
Jul 29 12:31:11 bdc-public-services app/web.1 Traceback (most recent call last):
Jul 29 12:31:11 bdc-public-services app/web.1   File "/app/app/workers/webhook_transfer.py", line 121, in transfer_all_webhook_items
Jul 29 12:31:11 bdc-public-services app/web.1     retry_list = await process_items(try_list)
Jul 29 12:31:11 bdc-public-services app/web.1   File "/app/app/workers/webhook_transfer.py", line 45, in process_items
Jul 29 12:31:11 bdc-public-services app/web.1     environ, guid, retry_count = list_key.split(":")
Jul 29 12:31:11 bdc-public-services app/web.1 AttributeError: 'NoneType' object has no attribute 'split'

Clearly the fact that None was used as a key in a processing list is also a bug. But we shouldn't crash because of it. That's this bug.

@brotskydotcom brotskydotcom added the bug Something isn't working label Jul 31, 2020
@brotskydotcom brotskydotcom added this to the v2.0.1 milestone Jul 31, 2020
@brotskydotcom brotskydotcom self-assigned this Jul 31, 2020
@brotskydotcom brotskydotcom added the duplicate This issue or pull request already exists label Jul 31, 2020
@brotskydotcom
Copy link
Owner Author

This is actually a symptom of #22. Closing this one as a dup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

1 participant