Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xref-find-references to xref-prompt-for-identifier #5

Closed
MaskRay opened this issue Dec 8, 2017 · 4 comments
Closed

Add xref-find-references to xref-prompt-for-identifier #5

MaskRay opened this issue Dec 8, 2017 · 4 comments

Comments

@MaskRay
Copy link
Contributor

MaskRay commented Dec 8, 2017

Expected behavior

xref-find-references reads the identifier at point, instead of reading it from the minibuffer.

Actual behavior

xref-find-references prompts for the identifier to look up.

This is because xref-find-references is not in xref-prompt-for-identifier.

Steps to reproduce (recipe)

Call xref-find-references at an identifier.

@brotzeit
Copy link
Owner

brotzeit commented Dec 8, 2017

I didn't know about that, thanks!
So you want xref-find-references to be in xref-prompt-for-identifier by default ?
I think this is a good idea, but helm-xref only displays the results provided by xref. Maybe you should send a patch to an emacs mailing list ? I don't think helm-xref should override xref settings, except the display method.

@MaskRay
Copy link
Contributor Author

MaskRay commented Dec 8, 2017

I send an email to help-gnu-emacs@gnu.org , don't know whether that would create an issue ...

@MaskRay MaskRay closed this as completed Dec 8, 2017
@brotzeit
Copy link
Owner

brotzeit commented Dec 8, 2017

From the manual

When you have all these pieces, bundle them up in a mail message and send it to the developers. Sending it to bug-gnu-emacs@gnu.org (which is the bug/feature list) is recommended, because that list is coupled to a tracking system that makes it easier to locate patches. If your patch is not complete and you think it needs more discussion, you might want to send it to emacs-devel@gnu.org instead. If you revise your patch, send it as a followup to the initial topic.

@MaskRay
Copy link
Contributor Author

MaskRay commented Dec 8, 2017

Thanks! I spelled the wrong mailing list in the first place. It is now reported at https://debbugs.gnu.org/cgi/bugreport.cgi?bug=29619

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants