Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we didn't remove tests that are not present in rust-mode #291

Closed
brotzeit opened this issue Oct 16, 2021 · 9 comments
Closed

Ensure we didn't remove tests that are not present in rust-mode #291

brotzeit opened this issue Oct 16, 2021 · 9 comments

Comments

@brotzeit
Copy link
Owner

It's possible that we've changed the tests that were once pulled from rust-mode during the last years. We removed those tests in #290, maybe there were changes in rustic that are worth restoring in rustic or rust-mode.

@brotzeit
Copy link
Owner Author

brotzeit commented Nov 3, 2021

@tarsius it seems you've applied some changes to test files that we removed. Do you think it makes sense to merge those changes into rust-mode ?

@tarsius
Copy link
Contributor

tarsius commented Nov 3, 2021

Where did I do that?

I probably won't be able to help you with this and similar decision. I don't remember such details as it has been such a long time and because I ended up not using rust (for the time being at least) I am also not particularly motivated to dig in again at this time.

But point me to the changes you are talking about and I will have a look. Who knows, maybe it rings a bell after all.

@brotzeit
Copy link
Owner Author

brotzeit commented Nov 3, 2021

It doesn't look important, but thanks for the quick reply. I'll keep it open, maybe I'm motivated to take a look some day =)

And hopefully you get a good reason to take a look at rust again ;)

@tarsius
Copy link
Contributor

tarsius commented Nov 3, 2021

If you are talking about the tests branch in my fork, then I know nothing about it. You wrote that change, I forked your repository, you deleted the branch from your repository, and I never got around to pruning old branches.

In fact I would like to prune these branches now. So please take a look at all the branches in my fork and move those that you would like to keep over to your repository and then tell me that you are done with that.

Except transient, I am probably going to keep that.

@brotzeit
Copy link
Owner Author

brotzeit commented Nov 3, 2021

If you are talking about the tests branch in my fork, then I know nothing about it.

I mean changes that were merged and afterwards removed.

It seems you already deleted the fork ? I can't find it under your repositories.

I only know that you were working on a transient pr. But I don't know which other feature branches you have. It would certainly be interesting to see that. And I especially would like to have the transient branch. I just noticed that @sehnsucht13 also started working on it two years ago #55

@tarsius
Copy link
Contributor

tarsius commented Nov 3, 2021

It seems you already deleted the fork ? I can't find it under your repositories.

It's at https://github.com/tarsiiformes/rustic.

I only know that you were working on a transient pr.

I actually just started wrapping that up. Would you be interested in that?

But I don't know which other feature branches you have.

I don't have any. Its just very old branches you authored. There's close to zero chance you would want to recover those, but because of my confusion about what test-changes you were talking about, I though I would mention them.

@tarsius
Copy link
Contributor

tarsius commented Nov 3, 2021

Please checkout the improved transient branch. I have completed the list of changes. I have also outlined how I think this should be further improved and added a proof-of-concept implementation of a "transified" cargo subcommand. It should be fairly easy to take it from here, and I can help with any transient-related issues (but not with the cargo-specific ones). Do you want me to open a pull-request?

@brotzeit
Copy link
Owner Author

brotzeit commented Nov 4, 2021

Sure, thanks.

@brotzeit
Copy link
Owner Author

brotzeit commented Jan 7, 2022

rust-lang/rust-mode#421

@brotzeit brotzeit closed this as completed Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants