-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure we didn't remove tests that are not present in rust-mode #291
Comments
@tarsius it seems you've applied some changes to test files that we removed. Do you think it makes sense to merge those changes into rust-mode ? |
Where did I do that? I probably won't be able to help you with this and similar decision. I don't remember such details as it has been such a long time and because I ended up not using rust (for the time being at least) I am also not particularly motivated to dig in again at this time. But point me to the changes you are talking about and I will have a look. Who knows, maybe it rings a bell after all. |
It doesn't look important, but thanks for the quick reply. I'll keep it open, maybe I'm motivated to take a look some day =) And hopefully you get a good reason to take a look at rust again ;) |
If you are talking about the In fact I would like to prune these branches now. So please take a look at all the branches in my fork and move those that you would like to keep over to your repository and then tell me that you are done with that. Except |
I mean changes that were merged and afterwards removed. It seems you already deleted the fork ? I can't find it under your repositories. I only know that you were working on a transient pr. But I don't know which other feature branches you have. It would certainly be interesting to see that. And I especially would like to have the transient branch. I just noticed that @sehnsucht13 also started working on it two years ago #55 |
It's at https://github.com/tarsiiformes/rustic.
I actually just started wrapping that up. Would you be interested in that?
I don't have any. Its just very old branches you authored. There's close to zero chance you would want to recover those, but because of my confusion about what test-changes you were talking about, I though I would mention them. |
Please checkout the improved |
Sure, thanks. |
It's possible that we've changed the tests that were once pulled from rust-mode during the last years. We removed those tests in #290, maybe there were changes in rustic that are worth restoring in rustic or rust-mode.
The text was updated successfully, but these errors were encountered: