Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

transcription and diplomatic divs with empty elements as contents don't display content #55

Closed
emylonas opened this issue Jan 30, 2020 · 2 comments
Assignees
Milestone

Comments

@emylonas
Copy link
Contributor

emylonas commented Jan 30, 2020

For ex: in .https://dlibwwwcit.services.brown.edu/iip/viewinscr/masa0295/
The contents of the transcription are:

<div type="edition" subtype="transcription" ana="b1" xml:lang="heb">
           <p>
               <g type="phoen-YOD"/><g type="phoen-NUN"/>
            </p>
</div>

the display shows [no transcription]

This is generated from one of the following files (found by grepping recursively for "no transcription"

./static/mapsearch/js/result_display.js:                $(domTarget).find(".transcription").append("<tei-div>[no transcription]</tei-div>");

./static/mapsearch/js/result_display.js:                $(domTarget).find(".transcription").html("[no transcription]");

./static/iip_search_app/js/result_display.js:                $(domTarget).find(".transcription").append("<tei-div>[no transcription]</tei-div>");

./static/iip_search_app/js/result_display.js:                $(domTarget).find(".transcription").html("[no transcription]");
./templates/iip_search_templates/results.html:                                    [no transcription]

Apparently the code is testing for a <div> element with no text() or spaces in it. However, the <g> elements generate content - they are standing in for non-displayable elements. In other cases, where there is a non-space text node, the <g> elements show up, because all content is pulled from the source file. See
https://dlibwwwcit.services.brown.edu/iip/viewinscr/masa0301/
This is probably true for diplomatic divs as well.

@emylonas emylonas added the bug label Jan 31, 2020
@emylonas emylonas added this to the now milestone Mar 17, 2020
@emylonas
Copy link
Contributor Author

@birkin masa0940c.xml has no transcription. It does have a diplomatic component.

            <div type="edition" subtype="diplomatic" ana="b1">
                <p>h<gap reason="lost" unit="character" extent="unknown"/></p>
            </div>
            <div type="edition" subtype="transcription" ana="b1">
                <p> </p>
            </div>

We shouldn't have any at that have no text at all.

@birkin
Copy link
Member

birkin commented Apr 20, 2020

@birkin birkin closed this as completed Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants