Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for copier.yml #497

Open
34j opened this issue May 3, 2023 · 2 comments · May be fixed by #681
Open

Improvements for copier.yml #497

34j opened this issue May 3, 2023 · 2 comments · May be fixed by #681
Labels
enhancement New feature or request

Comments

@34j
Copy link
Contributor

34j commented May 3, 2023

Is your feature request related to a problem? Please describe.
It's a pain to enter GITHUB_TOKEN, EMAIL and manually create the venv then install packages then run pre-commit.

Describe the solution you'd like
Use my jinja2_env to get GITHUB_TOKEN and EMAIL from environment variables and automate. Also create venv automatically by command. The operation must be different depending on the operating system. Example In addition, the copyright year can be automatically entered using jinja2_time. This allows more options to be turned on by default.

Additional context
Setting GITHUB_TOKEN as an environment variable is a security concern, but I think it is a win-win to implement as only those who have no concerns can use it. I think I can send a PR for this.

@34j 34j added the enhancement New feature or request label May 3, 2023
@34j 34j changed the title Further improvement for copier.yml Improvements for copier.yml May 3, 2023
@browniebroke
Copy link
Owner

You're suggesting a few things here, some I definitely agree with (generating copyright), while others I'm curious to see how they would look like (getting stuff from env variable).

I'm open to see how these would look like, maybe best to submit separate pull requests for them though, not sure I'll accept them all.

@34j
Copy link
Contributor Author

34j commented May 6, 2023

I think I should not send a PR at this time as it seems kind of difficult to have them merged. Thanks for your prompt replies and feedbacks. Sorry for cluttering up the Issue.

@34j 34j linked a pull request Mar 4, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants