Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Banner not being shown because "is latest version of the browser" #562

Open
ethaniel opened this issue Oct 29, 2022 · 0 comments
Open

Banner not being shown because "is latest version of the browser" #562

ethaniel opened this issue Oct 29, 2022 · 0 comments

Comments

@ethaniel
Copy link

ethaniel commented Oct 29, 2022

Hi!

I'm testing with user-agent Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_5) AppleWebKit/603.3.8 (KHTML, like Gecko) Version/10.1.2 Safari/603.3.8 (which belongs to one of my users and showed up in the Javascript error logs which get reported to me via Ajax).

According to your code: if (/os x 10.10/i.test(ua)) r.available.s = "10.1.2";, this is the latest possible version of the Safari browser for OS X 10.10 and cannot be updated, thus a banner is not displayed due to if (bb.is_latest) op.hide_reasons.push("is latest version of the browser");

However, this version of Safari is not playing well with the latest Javascript ES6, so I would prefer to have the banner shown and get the user to switch to Chrome.

Is it possible to add an hide_reasons override option to display the banner for such users?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant