Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is this script still maintained? i get a lot false positives, details inside #585

Open
mtbpm opened this issue Apr 11, 2024 · 2 comments
Open

Comments

@mtbpm
Copy link

mtbpm commented Apr 11, 2024

we have just upgraded to API 2024.04. our config is:

var $buoop={required:{e:-2,f:-2,o:-2,s:-2,c:-2},api:2024.04,insecure:!0,unsupported:!0,reminder:168,reminderClosed:720,newwindow:!0,shift_page_down:!1};function $buo_f(){var e=document.createElement("script");e.src="//browser-update.org/update.min.js",document.body.appendChild(e)}try{document.addEventListener("DOMContentLoaded",$buo_f,!1)}catch(e){window.attachEvent("onload",$buo_f)}

so i would expect:

  • the warning to show if the browser version is latest - 3 versions
  • the warning NOT to show if version is latest - 2 versions

i tested major browser versions in browserstack, here are the results:

Windows 11
Edge 123 (latest) --> no warning, correct
Edge 122 (latest - 1) --> no warning, correct
Edge 121 (latest - 2) --> no warning, correct
Edge 120 (latest - 3) --> no warning, wrong
Edge 119 (latest - 4) --> warning, correct
Firefox 124 (latest) --> no warning, correct
Firefox 123 (latest - 1) --> no warning, correct
Firefox 122 (latest - 2) --> warning, wrong
Firefox 121 (latest - 3) --> warning, correct
Chrome 123 (latest) --> no warning, correct
Chrome 122 (latest - 1) --> no warning, correct
Chrome 121 (latest - 2) --> warning, wrong
Chrome 120 (latest - 3) --> warning, correct

macOS
Safari 17.4 (latest) --> no warning, correct
Safari 17.3 (latest - 1 minor version) --> warning, wrong
Safari 16.5 (latest - 1 major version) --> warning, wrong

so my questions are:

  • can you confirm that the detection is buggy? or is this working as expected?
  • will it be fixed?

we have been users of this wonderful script for many years. but as we get so many false positives we are thinking about removing the script from our solution (which is by the way used by thousands of users daily).

thank you for your answer.

@josselex
Copy link
Contributor

Thanks for reporting. The script is still maintained. I will have a look into this the next days.

@josselex
Copy link
Contributor

Hi. You seems you have set "unsupported":true. This means you are also notifying all browsers that are not supported by the vendor anymore. That is why you see
e.g. Firefox 122 (latest - 2) --> warning, wrong
and Chrome 121 (latest - 2) --> warning, wrong

So this is a configuration issue.

Also I updeted the version now. so also this should be fixed:
Edge 120 (latest - 3) --> no warning, wrong

The Safari Safari getting notified I have to investigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants