Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typing on Mobile #15

Closed
o0101 opened this issue Nov 28, 2019 · 3 comments
Closed

Typing on Mobile #15

o0101 opened this issue Nov 28, 2019 · 3 comments
Labels
bug Something isn't working

Comments

@o0101
Copy link
Collaborator

o0101 commented Nov 28, 2019

For example, deleting
@o0101 o0101 added the bug Something isn't working label Nov 28, 2019
@o0101
Copy link
Collaborator Author

o0101 commented Jan 2, 2020

basically tho it's okay for now

because even tho it's incorrect there's feedback so it's possible to correct it

@o0101 o0101 closed this as completed Jan 2, 2020
@o0101 o0101 reopened this Jan 5, 2020
@o0101 o0101 closed this as completed Jan 13, 2020
@o0101
Copy link
Collaborator Author

o0101 commented Jan 23, 2020

this is because we keep the input value locally. as soon as we get backspace we should delete entire input value we have locally

@o0101 o0101 reopened this Jan 23, 2020
o0101 added a commit that referenced this issue Feb 14, 2020
@o0101
"Typing on mobile a little better.
01a03f3 
Only regards to backspace behaviour I believe.

Not perfect but I think some things are improved.

Re #15"
@o0101
Copy link
Collaborator Author

o0101 commented Feb 20, 2020

Another part of this I noticed is on iOS safari even when state.viewState.shouldHaveFocus ought to be an input, when 'space' is received the page will scroll. This ought to be disabled is an key input has focus.

@o0101 o0101 closed this as completed Feb 29, 2020
o0101 added a commit that referenced this issue Jul 17, 2020
@o0101
"Typing on mobile a little better.
6a6c10b 
Only regards to backspace behaviour I believe.

Not perfect but I think some things are improved.

Re #15"
vivekjishtu pushed a commit to vivekjishtu/browsergap.ce that referenced this issue Jul 27, 2020
@o0101
"Typing on mobile a little better.
7dc968f 
Only regards to backspace behaviour I believe.

Not perfect but I think some things are improved.

Re BrowserBox#15"
vivekjishtu pushed a commit to vivekjishtu/browsergap.ce that referenced this issue Jul 27, 2020
@o0101
"Typing on mobile a little better.
fb841a3 
Only regards to backspace behaviour I believe.

Not perfect but I think some things are improved.

Re BrowserBox#15"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@o0101