--require/-r seems to be broken when used with pipe input after browserify v4

[cymen]

Here is a repo with branches browserify_4, _5, _6, _7 to demonstrate:

https://github.com/cymen/browserify-pipe-issue/

It looks like it is the require that is breaking. For browserify v4, it works:

https://github.com/cymen/browserify-pipe-issue/blob/browserify_4/built/common.js

But after v4, the require for ./robot.js used in browserifying common.js does this (does not work):

https://github.com/cymen/browserify-pipe-issue/blob/browserify_5/built/common.js
https://github.com/cymen/browserify-pipe-issue/blob/browserify_6/built/common.js
https://github.com/cymen/browserify-pipe-issue/blob/browserify_7/built/common.js

I have the build with pipes approach in the package.json which is:

{
  ...
  "scripts": {
    "build_common": "cd lib && cat common.js | browserify -r ./robot.js - > ../built/common.js",
    "build_beep": "cd lib && cat beep.js | browserify -x ./robot.js - > ../built/beep.js",
    "build_bop": "cd lib && cat bop.js | browserify -x ./robot.js - > ../built/bop.js",
    "build": "npm run build_common && npm run build_beep && npm run build_bop",
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  ...
}

[gabrielecirulli]

👍 Can anyone confirm this?

[gabrielecirulli]

Hello? 😛

[joshfrench]

I'm also seeing this on Browserify 8.

[joshfrench]

Scratch that, this appears to just be a path issue. The following works as expected, with common.js including the source of robot.js and beep.js only referencing it:

# lib/common.js
var robot = require('./lib/robot');

# lib/beep.js
var robot = require('./lib/robot');

$ browserify -r ./lib/robot.js -o built/common.js - < lib/common.js
$ browserify -x ./lib/robot.js -o built/beep.js - < lib/beep.js